Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jump error when exiting char mode without entering target #53

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

bismarck2100
Copy link
Contributor

I found that when using char mode, user will get an error after pressing esc without enter any target char.
root cause: should check self.target before performing jump in char mode.
Thanks.

@ice9js
Copy link
Owner

ice9js commented Nov 16, 2016

Nice catch, thanks!

Hovever, I'm not sure how this is supposed to fix that? It looks like you moved the condition up from inside AceJumpCommand.jump to where it is called, which shouldn't really change anything since it was the first thing inside the method.

Please correct me if I'm missing something.

@bismarck2100
Copy link
Contributor Author

Thanks for quick reply~

In my opinion, it's because AceJumpCharCommand override the jump function.
When "jump" function is called in AceJumpCommand.submit , AceJumpCharCommand.jump will be invoked.

Thanks.

@ice9js
Copy link
Owner

ice9js commented Nov 16, 2016

Oh right, that makes sense. Thanks a lot!

@ice9js ice9js merged commit bc18fec into ice9js:master Nov 16, 2016
@bismarck2100 bismarck2100 deleted the patch-1 branch November 16, 2016 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants