-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added double character labels support #68
base: master
Are you sure you want to change the base?
Conversation
Thanks for taking the time to work on this. I see you started work on yet another feature which is great, but it would be nice if you could split it into separate branches/PRs. As for the double char labels support, I'm not entirely convinced this is the way to go. Screens tend to get bigger but more importantly, not everyone uses the same set of character for the labels. I'm thinking it's not uncommon for people to only use the keys from the home row and so they would need more combinations. A more universal approach would be to use Another issue I found is mainly present when jumping to characters. With two identical characters next to each other, their labels will overlap. I'm not really sure what we should do in this case right now so I wouldn't let it prevent us from moving forward though it's definitely something I'd like to address later. About the second feature - I think we could expand on existing |
P.S. You might also want to update |
Added double character labels support. and an option ("double_char_label") to toggle this feature.
The number of double-char labels is 2704 (26*2**2) by default, which is much more than the one of single-char labels. It is sufficient to cover full view of text in most cases, so that it is more intuitive to label the character under focus of your eyes at the first time instead of pressing "Enter" key several times to reach the character you want to go for.
screenshots attached to compare:
"double_char_label": true
"double_char_label": false (default)