Update lint #415
Merged
Update lint #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I think we should do this. However, this could be a potential nightmare for people doing analyses right now and have modified their |
Member
Author
|
Sure, no urgency and you can also just close this PR if it's not helpful. |
Collaborator
|
No blockers from my side. (If we need to touch this again in the future, I would suggest looking at |
JannisNe
approved these changes
Feb 20, 2025
jvansanten
added a commit
to jvansanten/flarestack
that referenced
this pull request
Jul 8, 2025
jvansanten
added a commit
that referenced
this pull request
Sep 5, 2025
* Use astropy Tables for data everywhere * Load npz file if present * Improve cache coherence in NTSeason.simulate_background Cuts time in Injector.create_dataset() from ~1500 ms to ~600 ms * CircularGaussian: do not attempt to modify data in-place * Blacken/isorten following #415 * Use Table for EffectiveAreaInjector * Annotate factory functions * Avoid modifying columns in place * Use instance variables in NorthernTracksKDE * Normalize KDE PDF to region of interest * Speed up TableInjector by a factor ~2 when drawing ~175 events from 11.5e6 MC events across 1000 sources * Speed up StaticFloor numpy broadcasting is much faster than a list comprehension * Cache effective injection time for steady sources There's no point in calculating this tens of thousands of times, since it's independent of the source for a steady time pdf * Remove upper bound on n_s * Squeeze the last bits of fluff out of StdMatrixKDEEnabledLLH.get_spatially_coincident_indices Unexpected bottlenecks: - Repeatedly slicing into astropy Tables (overhead from copying units) - Temporary arrays in ra_dist and angular_distance * Evaluate SoB for different gammas lazily Keys appear as before, but values are only evaluated when accessed. Speeds up initialization when gamma is not being fitted. * Use less accurate (but much faster) angular distance calculation in NorthernTracksKDE * Annotate PDF factory functions * HACK: allow StdMatrixKDEEnabledLLH to use CircularGaussian pdf * Revert "Annotate PDF factory functions" This reverts commit 9afa53e13556e783a73909fa2751ed98bad35f27. * Normalize gaussian PDF * WIP: King function PSF * chore: annotate BaseInjector * Allow Season to simulate background only in the source box * Evaluate energy SoB lazily * Add log of King PDF * Add an option to disable energy S/B interpolation The 2nd-order spline interpolation does not necessarily reflect the normalization of the underyling signal or background energy PDFs * Use splines for King PDF parameters * Speed up make_season_weight 10x 180 ms -> 11 ms for 22k sources * Microoptimization: sparse matrix projection 25% faster * Microoptimization: slice result of background pdf calculation instead of inputs * mypy cleanup * Guard annotation-only imports * Cosmetic: raw string for latex * Return excluded events from create_dataset in unblinded injectors * Consider excluded events in flare likelihoods (but require ==0) * Handle unbounded n_s in 1D llh scan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump black version, add isort for prettifying dependencies, add option for pre-commit.
Nearly every file is affected by this PR, but the changes in almost all files are cosmetic.