Skip to content

Icetop effective area fix 2try#22

Merged
kjmeagher merged 4 commits intomainfrom
icetop_fix_2try
Oct 31, 2023
Merged

Icetop effective area fix 2try#22
kjmeagher merged 4 commits intomainfrom
icetop_fix_2try

Conversation

@matthiasplum
Copy link
Contributor

Okay the second try of getting the effective area fixed. The solution is to use the NaturalRateCylinder injector with a side length of zero.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/simweights/_icetop_weighter.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@matthiasplum matthiasplum self-assigned this Oct 30, 2023
Copy link
Contributor

@kathrawlins kathrawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@kjmeagher kjmeagher merged commit 9ab1331 into main Oct 31, 2023
@kjmeagher kjmeagher deleted the icetop_fix_2try branch October 31, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants