Skip to content

Conversation

@mjlarson
Copy link
Contributor

@mjlarson mjlarson commented Aug 29, 2024

Apparently the genie weighting never worked since it was missing the cos_zen variable. This PR adds that in so that simweights works for genie-reader files. There's also an upper limit requirement added for numpy since nuflux won't accept numpy2 yet. That can be removed if needed.

A PR for icetray/genie-reader (icecube/icetray#3607) scales the generation volume based on the energy of the most energetic daughter muon. I'll be adding the necessary bits here to account for that as well.

@github-actions
Copy link

github-actions bot commented Aug 29, 2024

Test Results

  6 files  ±0    6 suites  ±0   3m 7s ⏱️ -1s
 94 tests ±0   94 ✅ ±0  0 💤 ±0  0 ❌ ±0 
564 runs  ±0  563 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit 35fddd5. ± Comparison against base commit b4a664f.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
tests.test_genie_weighter.TestCorsikaWeighter ‑ test_triggered_corsika
tests.test_genie_weighter.TestGenieWeighter ‑ test_genie

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b4a664f) to head (35fddd5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          749       755    +6     
=========================================
+ Hits           749       755    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjlarson mjlarson marked this pull request as ready for review August 29, 2024 19:22
@kjmeagher kjmeagher merged commit 4290c55 into main Aug 29, 2024
@kjmeagher kjmeagher deleted the genie_weighting branch August 29, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants