Skip to content

GSF CubicInterpolation oscillation fix. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kjmeagher merged 2 commits into from
Nov 21, 2024
Merged

GSF CubicInterpolation oscillation fix. #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bcfffa
changed cubic spline to Pchip, fix #45
The-Ludwig Nov 21, 2024
4bc2756
add test for #45
The-Ludwig Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/simweights/_fluxes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

from numpy import asarray, bool_, broadcast_arrays, exp, float64, genfromtxt, int32, piecewise, sqrt
from numpy import sum as nsum
from scipy.interpolate import CubicSpline # pylint: disable=import-error
from scipy.interpolate import PchipInterpolator # pylint: disable=import-error

from ._pdgcode import PDGCode

Expand Down Expand Up @@ -345,7 +345,7 @@ def __init__(self: GlobalSplineFitBase) -> None:
self._funcs = []
for z_low, z_high in self.groups:
self._funcs.append(
CubicSpline(energy, nsum(elements[z_low - 1 : z_high], axis=0), extrapolate=False, axis=0),
PchipInterpolator(energy, nsum(elements[z_low - 1 : z_high], axis=0), extrapolate=False, axis=0),
)


Expand Down
Loading