Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary String allocation #1106

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Remove unnecessary String allocation #1106

merged 2 commits into from
Nov 10, 2021

Conversation

RamType0
Copy link
Contributor

@RamType0 RamType0 commented Nov 1, 2021

Remove unnecessary String allocation by passing &format! or &x.to_string as impl Into<String>

@RamType0
Remove unnecessary String allocation
0245f28 
Remove unnecessary String allocation by passing &format! or &x.to_string as impl Into<String>
hecrj
hecrj approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I think we should get clippy involved in our CI eventually to avoid pitfalls like these ones when APIs change.

@hecrj hecrj added the improvement An internal improvement label Nov 4, 2021
@hecrj hecrj added this to the 0.4.0 milestone Nov 4, 2021
@hecrj hecrj merged commit f084ed8 into iced-rs:master Nov 10, 2021
@hecrj hecrj mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
improvement An internal improvement
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@RamType0 @hecrj