Pass ignored events to program #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaimast
commented
Feb 3, 2022
native/src/program/state.rs
Outdated
| @@ -153,7 +152,17 @@ where | |||
| self.cache = Some(user_interface.into_cache()); | |||
|
|
|||
| Some(commands) | |||
| }; | |||
|
|
|||
| // Allow for the program to handle any uncaptured event | |||
There was a problem hiding this comment.
I needed to move this down here to make the borrow checker happy
hecrj
force-pushed
the
feat/ignored_events
branch
from
a7d9d19
to
c9b8dbd
Compare
hecrj
added
improvement
|
Either is fine. Thanks so much for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to make the issues addressed in #408 a little easier to solve. Currently, you have to re-implement
program::Statewhich seems like a bad idea just to capture events.I think in the future iced needs to receive proper focus handling, but for now this change would be very helpful for me at least.