Replace window::Mode with window commands
#1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
added
bug
Additionally, only show the window once one frame has been rendered to avoid blank flashes on Windows.
hecrj
force-pushed
the
refactor-window-mode
branch
from
cf46779 to
277b848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declarative
Application::modeapproach does not work well because an OS can change the window mode without askingicedfor permission, eventually leading to desynchronization.Therefore, the current design should be replaced with a
Command-based approach where the mode of a window is assumed to be external and can be queried at will.Additionally, this better design allows us to make the window visible only when a frame has been rendered to avoid the "blank window flash" on Windows.
TODO
windowcommands to control and query window mode.Closes #261.