Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't double translate text clip inside canvas #1411

Merged
merged 1 commit into from
Aug 16, 2022

Conversation

tarkah
Copy link
Member

@tarkah tarkah commented Aug 15, 2022

The clip bounds is already inside a Translate, so using region offsets the clip bounds by translate again. Clip within the translate should start at origin w/ region size.

@tarkah tarkah changed the title Don't double translate text clip Don't double translate text clip inside canvas Aug 15, 2022
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch.

@hecrj hecrj merged commit 4425839 into iced-rs:master Aug 16, 2022
@hecrj hecrj added the bug Something isn't working label Aug 16, 2022
@hecrj hecrj modified the milestones: 0.4.3, 0.5.0 Aug 16, 2022
@tarkah tarkah deleted the fix/canvas-with-clip-text branch August 30, 2022 15:33
tarkah pushed a commit to tarkah/iced that referenced this pull request Sep 2, 2022
Don't double translate text clip inside canvas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants