non uniform border radius for quads #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature is quite useful to for example render more sophisticated buttons. It's similar to the CSS border-radius property.
Happy to address potential concerns. |
hecrj
force-pushed
the
non-uniform-border-radius-for-quads
branch
from
3875a46 to
15f2164
Compare
hecrj
approved these changes
Dec 2, 2022
|
Thanks for adding this! Stoked to see how much development is happening around iced! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows quads to be rendered with different border radius values. It only modifies quads, not yet any widgets based on that. I tried to open a discussion about the implications of changing the API of widgets such as button over here but didn't receive any feedback.
A project showing the use of that can be found over here: https://github.com/rksm/iced-non-uniform-border-radius.