Additional cfg for wasm target for gradients #1524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage buffers aren't supported by wgpu WASM + webgl which gradients currently use. For now I've just added a
#cfg
around relevant bits of code so WASM targets that don't use gradients will compile as expected.Not quite sure if there is a preferred way to separate out this code, but I figured writing a separate implementation for WASM which uses a static uniform array like the GL target would be a relatively simple process so it didn't make sense to reorganize the code to reduce the number of target-specific compilation exclusions.