Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize images on README.md #1659

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Resize images on README.md #1659

merged 3 commits into from
Feb 7, 2023

Conversation

Sn-Kinos
Copy link
Contributor

@Sn-Kinos Sn-Kinos commented Jan 19, 2023

Overview

I resized image on README.md to match the proportion.

Changes

PC Layouts

Before --> After

imageimage

Mobile Layouts

image

It shows well on mobile too! 😎

Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce the "Before" image shared here on my setup. @casperstorm Any thoughts on this?

@Sn-Kinos
Copy link
Contributor Author

I can't reproduce the "Before" image shared here on my setup. @casperstorm Any thoughts on this?

Oh, I forgot to tell you which environment the bug is from. This bug occurs on Safari 16.2 @ macOS Ventura.

Copy link
Member

@casperstorm casperstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce this on Safari as well. This is fixing it.

@hecrj hecrj added improvement An internal improvement documentation labels Feb 7, 2023
@hecrj hecrj added this to the 0.8.0 milestone Feb 7, 2023
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you 🎉

@hecrj hecrj enabled auto-merge (squash) February 7, 2023 19:20
@hecrj hecrj disabled auto-merge February 7, 2023 20:20
@hecrj hecrj merged commit 92ba26b into iced-rs:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improvement An internal improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants