Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make image support optional in iced_wgpu #166

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Make image support optional in iced_wgpu #166

merged 1 commit into from
Jan 20, 2020

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Jan 20, 2020 •
edited
Loading

Depends on #164.

This PR makes image rendering support optional, allowing us to turn image into an optional dependency in iced_wgpu.

An application needs to enable the new image feature before being able to use an Image widget. As a consequence, the compilation time and binary size of applications that do not need image rendering is reduced.

For instance, the counter example has seen a reduction of 1.3M in binary size on my Linux environment.

@hecrj
Make image support optional in iced_wgpu
bc611cf 
This reduces binary size when image rendering is not necessary a
considerable amount.
@hecrj hecrj added improvement An internal improvement feature New feature or request labels Jan 20, 2020
@hecrj hecrj added this to the 0.1.0 milestone Jan 20, 2020
@hecrj hecrj self-assigned this Jan 20, 2020
@hecrj hecrj merged commit 1ef7d09 into feature/custom-runtime Jan 20, 2020
@hecrj hecrj deleted the optional-image-support branch January 20, 2020 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hecrj hecrj

Labels
feature New feature or request improvement An internal improvement
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@hecrj