Remove logging large bytes arrays #1731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed a huge impact on startup time when logging is enabled w/
iced
due to large byte arrays getting printed to the terminal. This is due to the font bytes that are debugged, as well as the winit icon bytes that is debugged.We log the
winit::WindowBuilder
directly, so I don't have access to customize how that is logged. This will require an upstream fix, if accepted. In the meantime, I think it's fair to log that struct asdebug
instead ofinfo
. We already log the iced window settings oninfo
anyways.I noticed there was already a fix for this on the glow side for default_font bytes. I've flipped this to
is_some
since it makes more sense thedefault_font: true
meansdefault_font: is_some / Some
, meaning a default font was provided.