Add scroll_to operation
#1796
Add scroll_to operation
#1796
Conversation
| pub struct CurrentOffset { | ||
| /// The [`AbsoluteOffset`] of a [`Scrollable`] | ||
| pub absolute: AbsoluteOffset, | ||
| /// The [`RelativeOffset`] of a [`Scrollable`] | ||
| pub relative: RelativeOffset, | ||
| } |
There was a problem hiding this comment.
There's some redundancy here.
I think it'd be better to have a Window or Viewport type with the already existing private Offset, the content bounds, and the scrollable bounds.
Then we can expose relative_offset and absolute_offset methods in this type that compute the actual values from a single source of truth.
There was a problem hiding this comment.
Great suggestion 6ad5e03
There was a problem hiding this comment.
Awesome!
I have made a change to compare the absolute offsets as well in notify_on_scroll, since it's theoretically possible that the relative offset stays the same but the absolute offset doesn't (e.g. if the bounds of the Scrollable change while scrolling). See 8a71140.
I think we can merge! 🚢
Supersedes #1795
Exposes a new
scroll_tooperation to allow scrolling a scrollable to a desired "absolute" offset.