Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add enabled_buttons to Settings to configure winit::window::WindowBuilder #2035

Closed
wants to merge 1 commit into from
Closed

feat: Add enabled_buttons to Settings to configure winit::window::WindowBuilder #2035

wants to merge 1 commit into from

Conversation

leoshimo
Copy link

@leoshimo leoshimo commented Aug 17, 2023 •
edited
Loading

POC plumbing for window button configuration via iced::Settings API per #2033

@leoshimo leoshimo changed the title feat: Add enabled_buttons to Settings to configure winit::window::Set… feat: Add enabled_buttons to Settings to configure winit::window::WindowBuilder Aug 17, 2023
hecrj
hecrj reviewed Aug 20, 2023
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API changes need a discussion and coordination beforehand!

Please, read the CONTRIBUTING.md guide.

@hecrj hecrj closed this Aug 20, 2023
@hecrj hecrj added the feature New feature or request label Aug 20, 2023
@hecrj hecrj added this to the 0.11.0 milestone Aug 20, 2023
@hecrj hecrj added the shell label Aug 20, 2023
@leoshimo
Copy link
Author

Hey @hecrj - I appreciate you taking a look + triaging.

I've read the CONTRIBUTING.md guide - I should've marked this as a draft PR, my mistake. The discussion I started is linked here: #2033.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj left review comments

Assignees
No one assigned
Labels
feature New feature or request shell
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@leoshimo @hecrj