[Fix] PaneGrid click interaction on the top edge
#2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhff
force-pushed
the
fix/pane_grid_top_edge_click
branch
from
7856853
to
116fb66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Clicking on the top edge of a
PaneGridexpands the clicked pane and pushes all other panes on the top row to below.This occurs because clicking a pane directly leads to a
Draggingaction, that, once button is released, willdropthepaneon the topedge.Solution
This PR adds a new
action,Clicking, which will only jump toDraggingif cursor moves a given deadband distance from the original click position. I have defined this deadband distance as10pixels, but let me know if it is too short/wide.Result