Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themer widget #2209

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Themer widget #2209

merged 2 commits into from
Jan 22, 2024

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Jan 21, 2024 •
edited
Loading

This PR removes the Theme associated type in the Renderer trait and introduces a Theme generic type in Widget instead.

Additionally, this PR implements a new widget: Themer, which can be used to apply any given theme type to any subtree of the view tree.

@hecrj hecrj added improvement An internal improvement change labels Jan 21, 2024
@hecrj hecrj added this to the 0.12 milestone Jan 21, 2024
@hecrj hecrj added feature New feature or request widget addition labels Jan 21, 2024
@hecrj hecrj changed the title Convert Renderer::Theme to generic Widget type Themer widget Jan 21, 2024
@hecrj hecrj merged commit 416e002 into master Jan 22, 2024
26 checks passed
@hecrj hecrj deleted the remove-associated-theme branch January 22, 2024 10:48
@0x192 0x192 mentioned this pull request Jan 23, 2024
Closed
2 tasks
@hecrj hecrj mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
addition change feature New feature or request improvement An internal improvement widget
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
1 participant
@hecrj