Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QR Code Styling #2229

Merged
merged 5 commits into from
Feb 9, 2024
Merged

QR Code Styling #2229

merged 5 commits into from
Feb 9, 2024

Conversation

clarkmoody
Copy link
Contributor

Screenshot 2024-02-02 at 11 17 47

API Changes

  • New style::qr_code module
  • New theme::QRCode enum
  • [BREAK] QR Code widget struct loses the light and dark fields in favor of a style field, similar to other widgets

@hecrj hecrj added feature New feature or request widget styling addition labels Feb 2, 2024
@hecrj hecrj added this to the 0.12 milestone Feb 2, 2024
hecrj
hecrj approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks 🎉

I have made a small change to automatically invalidate the canvas::Cache of the QRCode whenever the Appearance changes between draw calls.

@hecrj hecrj enabled auto-merge February 9, 2024 23:00
@hecrj hecrj merged commit 7ee00e7 into iced-rs:master Feb 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
addition feature New feature or request styling widget
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@clarkmoody @hecrj