Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quad shadows #2354

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Fix quad shadows #2354

merged 2 commits into from
Mar 27, 2024

Conversation

Koranir
Copy link
Contributor

@Koranir Koranir commented Mar 26, 2024 •
edited
Loading

Fixes #2288

Before:
image

After:
image

@hecrj hecrj added bug Something isn't working rendering styling fix labels Mar 26, 2024
@hecrj hecrj added this to the 0.13 milestone Mar 26, 2024
hecrj
hecrj approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, we were not considering the shadow offset!

Thanks! 🙇

@hecrj hecrj merged commit 5071e3d into iced-rs:master Mar 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecrj hecrj hecrj approved these changes

Assignees
No one assigned
Labels
bug Something isn't working fix rendering styling
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

Custom Quad's drop shadow broken
2 participants
@Koranir @hecrj