Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose physical keys #2523

Closed
wants to merge 1 commit into from

Conversation

Exidex
Copy link
Contributor

@Exidex Exidex commented Jul 26, 2024

Expose winit physical keys, aka native key codes. Useful for shortcuts that a based on actual position of keys.

The data model basically just a copy from winit with some changes:

  • unreachable!() in conversion function because of non_exhaustive, there is non_exhaustive_omitted_patterns lint which could help, but it is nightly-only
  • removed serde feature
  • added #![allow(missing_docs)] on top of file
  • run cargo fmt with several small styling changes to make ci/cd happy

Alternative would be to re-export types from winit. Let me know which one do you prefer. winit is abstracted away

Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Made some changes in #2576, since you didn't give me permissions to change your branch.

@hecrj hecrj closed this in #2576 Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants