Add compact variant for pane grid controls #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtkennerly
force-pushed
the
feature/pane-grid-compact-controls
branch
from
18c0f15
to
3a434c9
Compare
|
Not sure what the Mac failure is about. There's no specific error message that I can see: |
hecrj
reviewed
Aug 23, 2024
Comment on lines
+50
to
+59
| impl<'a, Message, Theme, Renderer> From<Element<'a, Message, Theme, Renderer>> | ||
| for Controls<'a, Message, Theme, Renderer> | ||
| where | ||
| Theme: container::Catalog, | ||
| Renderer: core::Renderer, | ||
| { | ||
| fn from(value: Element<'a, Message, Theme, Renderer>) -> Self { | ||
| Self::new(value) | ||
| } | ||
| } |
hecrj
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
The PaneGrid logic is getting quite complicated.
I wonder if at some stage we could make a Controls trait and allow users to fine-tune this kind of logic to their liking. Maybe we can think about that if we ever need further control.
Overall looks good! Let's merge! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when the pane grid controls would overlap with the title content, we hide the title content altogether. That's good for avoiding visual issues, but can be confusing for a user when the title content is also interactable and disappears when they try to select it. This PR adds an alternative compact variant to the pane grid controls, which allows overlap.