slider: handle mouse wheel events #2565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
slider
+vertical_slider
handle mouse wheel events -- i.e. when hovered, scrolling the mouse wheel will modify the slider.Question: currently the slider is incr/decremented by
self.step
for bothScrollDelta::Pixels
andScrollDelta::Lines
. This seems appropriate forLines
, but I'm not sure aboutPixels
. (It felt fine to me when testing, but I'm not sure what the "expected" behaviour is.)