fix: circular progress no longer skips #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvolk131
changed the title
tvolk131
changed the title
hecrj
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on master, the loading spinners example has a bug where the position of the active indicator (the highlighted part) skips ~90 degrees at the end of every animation cycle. This bug was introduced here:
b193298#diff-7d796743c0a1456ea9a47db8034601be8cc1374f9846ea8a42368fbf0c8082d8
Since we're casting the number of circle rotations (radians / 2 PI) to a
u32, we want to multiply byu32::MAX, notf64::MAX