Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Application configuration with Settings #68

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

hecrj
Copy link
Member

@hecrj hecrj commented Nov 25, 2019

This PR allows basic configuration (just the window size, for now) of an Application using the new Settings type.

@hecrj hecrj added the feature New feature or request label Nov 25, 2019
@hecrj hecrj added this to the 0.1.0 milestone Nov 25, 2019
@hecrj hecrj self-assigned this Nov 25, 2019
Comment on lines +16 to +22
pub struct Window {
/// The size of the window.
pub size: (u32, u32),

/// Whether the window should be resizable or not.
pub resizable: bool,
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the title field and fullscreen field would be nice as well. But the user should be able to dynamically change the size.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is meant to be dynamic, Application::title already addresses that.

I think we should research a bit before adding fullscreen support. I rarely use GUI apps that start in fullscreen mode by default.

I am also not sure if making the size dynamic, like the title, is a good idea. Applications resizing themselves can cause bad UX. I'd like to gather some use cases first.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to say that the user should be able to switch between normal windows size, to maximized, or to fullscreen. I also remember reading some solutions that recommended making the window size a bit bigger than the screen, hence the fullscreen.

@hecrj hecrj merged commit 84874ac into master Nov 25, 2019
@hecrj hecrj deleted the feature/application-settings branch November 25, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant