Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaneGrid Events in Title Bar Area #892

Merged
merged 3 commits into from
May 25, 2021
Merged

Conversation

clarkmoody
Copy link
Contributor

This work adds event handling from within the title area of the TitleBar, in addition to the existing functionality of the controls area. It might be useful to pane grid users to be able to have buttons on both sides of the title bar.

The pane_grid example app is updated to:

  • Have a Close button in the pane controls area
  • Have a Pin/Unpin button in the title area that prevents that pane from being closed
Screen.Recording.2021-05-24.at.5.16.06.PM.mov

Refactors the state data structure to hold content and controls in
separate fields. Adds a new button style for the control button.
Functionality will not work until PaneGrid implementation is updated
to support events within the title area.
Shrink the pick area to avoid both the controls and the title elements.
Handle events and merge title area event status with control events.
@hecrj hecrj added the feature New feature or request label May 25, 2021
@hecrj hecrj added this to the 0.4.0 milestone May 25, 2021
Copy link
Member

@hecrj hecrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants