-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make scrolling behave like you'd expect it to #95
Conversation
Ohhh, i completely forgot about the null renderer! Lemme fix this really quickly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Friz64! I tested it and it works nicely! 🎉
There are a couple of implementation details that I think we should address before merging.
Let me know what you think!
Oh, I forgot to mention that it'd be great if you could squash the |
f647a54
to
6b25b4d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Friz64,
I have introduced a Scrollbar
type and tried to refactor things a bit. I hope I didn't break anything! Let me know what you think.
Thank you for those changes, the idea of a |
Awesome! Yes, let's merge this! 🎉 Thank you again! |
This PR adds proper scrolling logic to the
scrollable
widget.Here i define a "floater" to be the element that you can drag around with your mouse to scroll.
The new behaviour is the following: