Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add Student CSFA Accomodation Section to Student Application Endpoint Response #31

Conversation

klondikemarlen
Copy link
Member

@klondikemarlen klondikemarlen commented Aug 14, 2023

Relates to icefoganalytics/student-financial-aid#2
Fixes #30

Context

As part of the "view submitted applications and their current status" project, this task covers returning the student CSFA accommodations data.

Implementation

Decide to standardize spelling in back end, because I don't want to propagate the typos. I'd rather require the front-end be fixed to match.

Data Format

{
  "id": "some-application-id",
  "csfaAccommodation": {
    "accommodations": [
      {
        ...
      }
   ],
  },
}

Testing Instructions

  1. Boot the sfa-client repo via API_PORT=3100 dev up
  2. Boot the student-financial-aid front- and back-ends.
  3. Log in to the app at http://localhost:8080/
  4. Go to http://localhost:3000/api/portal/students/1/applications/2198 and you will see an example of some accommodations.

@klondikemarlen klondikemarlen added the enhancement New feature or request label Aug 14, 2023
@klondikemarlen klondikemarlen self-assigned this Aug 14, 2023
Decide to standardize spelling in back end, because I don't want to propagate the typos. I'd rather require the front-end be fixed to match.
@klondikemarlen klondikemarlen force-pushed the issue-30/add-student-csfa-accomodation-section-to-student-application-endpoint-response branch from e09af7e to 8f28861 Compare August 14, 2023 20:34
@klondikemarlen klondikemarlen marked this pull request as ready for review August 14, 2023 20:40
Copy link

@datajohnson datajohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that spelling mistake today too...

@datajohnson datajohnson merged commit dc7ca16 into issue-28/add-student-dependents-section-to-student-application-endpoint-response Aug 16, 2023
@datajohnson datajohnson deleted the issue-30/add-student-csfa-accomodation-section-to-student-application-endpoint-response branch August 16, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants