Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add Student CSFA Income and Expenses Sections to Student Application Endpoint Response #35

Conversation

klondikemarlen
Copy link
Member

@klondikemarlen klondikemarlen commented Aug 14, 2023

Relates to icefoganalytics/student-financial-aid#2
Fixes #33

Context

As part of the "view submitted applications and their current status" project, this task covers returning the student CSFA income and expenses data.

Data Format

{
  "id": "some-application-id",
  "csfaIncome": { "incomes": [] },
  "csfaExpenses": { "expenses": [] },
}

Testing Instructions

  1. Boot the sfa-client repo via API_PORT=3100 dev up
  2. Boot the student-financial-aid front- and back-ends.
  3. Log in to the app at http://localhost:8080/
  4. Go to http://localhost:3000/api/portal/students/5/applications/3808 and you will see the empty CSFA income and CSFA expenses fields.
  5. Go to http://localhost:3000/api/portal/students/124478/applications/30356 and you will see some CSFA income values.
  6. Go to http://localhost:3000/api/portal/students/8634/applications/1995 and you will see some CSFA expense values.

@klondikemarlen klondikemarlen added the enhancement New feature or request label Aug 14, 2023
@klondikemarlen klondikemarlen self-assigned this Aug 14, 2023
@klondikemarlen klondikemarlen force-pushed the issue-33/add-student-csfa-income-section-to-student-application-endpoint-response branch from f33e429 to d9ed5e0 Compare August 14, 2023 23:44
@klondikemarlen klondikemarlen force-pushed the issue-33/add-student-csfa-income-section-to-student-application-endpoint-response branch from d9ed5e0 to 6d57e9e Compare August 14, 2023 23:44
@klondikemarlen klondikemarlen marked this pull request as ready for review August 14, 2023 23:48
@klondikemarlen klondikemarlen changed the title Enhancement: Add Student CSFA Icome and Expenses Sections to Student Application Endpoint Response Enhancement: Add Student CSFA Income and Expenses Sections to Student Application Endpoint Response Aug 14, 2023
Base automatically changed from issue-30/add-student-csfa-accomodation-section-to-student-application-endpoint-response to issue-28/add-student-dependents-section-to-student-application-endpoint-response August 16, 2023 22:22
Copy link

@datajohnson datajohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@datajohnson datajohnson merged commit b9d7278 into issue-28/add-student-dependents-section-to-student-application-endpoint-response Aug 16, 2023
@datajohnson datajohnson deleted the issue-33/add-student-csfa-income-section-to-student-application-endpoint-response branch August 16, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants