forked from ytgov/travel-authorization
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 1: Departmental Administration: Create a Travel Auth for Another Employee Within My Department #170
Merged
klondikemarlen
merged 12 commits into
main
from
issue-166/departmental-administration-create-a-travel-auth-for-another-employee-within-my-department
Jan 22, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I would make pat_admin and td_user into readable names, but I don't know what they mean.
I would make pat_admin and td_user into readable names, but I don't know what they mean.
Why? To make these files easier to distinguish from other types of files.
…e search. Why? This will trigger input after the user stops typing, which can be better used by computed properties that depends on typed input. e.g. const isDisabled = computed(() => isEmpty(travelerEmail.value)) Was not being triggered before after the user stopped typing which was a bit confusing.
The modal pops-up but there is no mechanism to get to the newly added form to fill it out. We should consider where this button is put. The manager view is likely not the appropriate place for it. Maybe the Travel Request Grid. |
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Context
Give department admins the ability to create travel authorizations for another employee in there department.
Requirements
department_admin
for better future readability.Implementation
Opted to go with adding the button to /manage-travel-requests page because I don't want to deal with code mess in the /travel-request component tree.
Support basic travel authorization creation for user's other than the current user, for admins.
Screenshots
Travel Authorization Creation modal

Testing Instructions
dev test
(ordev test_api
)dev up