Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 1: Departmental Administration: Create a Travel Auth for Another Employee Within My Department #170

Conversation

klondikemarlen
Copy link
Member

@klondikemarlen klondikemarlen commented Jan 22, 2024

Relates to:

Context

Give department admins the ability to create travel authorizations for another employee in there department.

Requirements

  • utilize the same UI as the /my-travel-requests, but will require the ability to pick the user the travel request is applied to.
  • create travel request for other user button could be located in the /manage-travel-requests page or the /travel-request pages. /travel-request should be renamed to /travel-requests
  • Route for edit access should be /travel-requests/46/details/edit
  • Rename DEPT_ADMIN = "dept_admin", to department_admin for better future readability.

Implementation

Opted to go with adding the button to /manage-travel-requests page because I don't want to deal with code mess in the /travel-request component tree.
Support basic travel authorization creation for user's other than the current user, for admins.

Screenshots

Travel Authorization Creation modal
image

Testing Instructions

  1. Run the test suite via dev test (or dev test_api)
  2. Boot the app via dev up
  3. Log in to the app at http://localhost:8080
  4. Go to the "Manager View" via the top drop down menu (http://localhost:8080/manage-travel-requests)
  5. Click on the "Create Travel Request" button to open the dialog.
  6. Add an email to unlock the create button.
  7. Click the "create" button to create the travel authorization and be redirected to the, in progress, travel authorization details edit page.

NOTE: the travel authorization edit page has not been implemented

I would make pat_admin and td_user into readable names, but I don't know what they mean.
I would make pat_admin and td_user into readable names, but I don't know what they mean.
Why? To make these files easier to distinguish from other types of files.
…e search.

Why? This will trigger input after the user stops typing, which can be better used by computed properties that depends on typed input.

e.g.
const isDisabled = computed(() => isEmpty(travelerEmail.value))

Was not being triggered before after the user stopped typing which was a bit confusing.
@klondikemarlen klondikemarlen added the enhancement Adds or modifies features to improve functionality or user experience. label Jan 22, 2024
@klondikemarlen klondikemarlen self-assigned this Jan 22, 2024
@klondikemarlen klondikemarlen changed the title Departmental Administration: Create a Travel Auth for Another Employee Within My Department Part 1: Departmental Administration: Create a Travel Auth for Another Employee Within My Department Jan 22, 2024
@klondikemarlen klondikemarlen marked this pull request as ready for review January 22, 2024 23:12
@klondikemarlen klondikemarlen merged commit 05c6ae3 into main Jan 22, 2024
@klondikemarlen klondikemarlen deleted the issue-166/departmental-administration-create-a-travel-auth-for-another-employee-within-my-department branch January 22, 2024 23:13
@dpdavids
Copy link

The modal pops-up but there is no mechanism to get to the newly added form to fill it out.

We should consider where this button is put. The manager view is likely not the appropriate place for it. Maybe the Travel Request Grid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds or modifies features to improve functionality or user experience.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants