-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tree experiment #7
Conversation
Preparation for inverse
Add --all-targets
Merged from latest master at: https://github.com/sfackler/cargo-tree
syn seems to have some problems parsing at least one of the indirect dependencies of this project, will add som fault tolerance to allow partial results being reported to the user and try updating syn.
(cherry-picking commit 68495c2)
(cherry-picking commit 7da84b0)
An expression like `str::from_utf8_unchecked(bytes)` should be counted as one unsafe expression. That is, just `str::from_utf8_unchecked` and `bytes` by themselves are not expressions that can meaningfully be considered unsafe. A way to see this is that there would never be a reason to write: unsafe { f }(unsafe { x })
Holy crap. Are you sure you don't want to just make your own crate? 😁 |
I just pushed up cherry picking from master, pretty sure it's in sync again.
Maybe? If you don't think this is the direction for cargo-osha I will make a new repos and crate. I don't feel the need to have it under my github user though, it's like max 10% that's my code in this PR, the rest is the original cargo-osha on top of cargo-tree. :) |
Trying to please github merge.
Conflicts fixed. Feel free to review, merge or just close :) |
I did what you suggested and created a new project: https://crates.io/crates/cargo-geiger If you want to merge the projects later that would be totally fine with me. Thanks for the nice and simple code btw! 👍 Closing. |
Solves: #3
Solves: #2
This is not ready to merge, I took a whole lot of liberty with this PR
and it is missing the commits from the last 24 hours or so.The history is a bit unexpected since I merged in
cargo-tree
as boiler plate, most of it is still there. That seemed like a reasonable approach to me sincecargo-tree
already had the recursive dependency walking in place but was not packaged up as a library and needed some modifications.Does this PR seem like a good direction at all for cargo-osha?
What should change?
What is missing?