Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign for optional titles or tags #11

Merged
merged 6 commits into from
Oct 7, 2024
Merged

Redesign for optional titles or tags #11

merged 6 commits into from
Oct 7, 2024

Conversation

icereed
Copy link
Owner

@icereed icereed commented Oct 7, 2024

First screen

image

Review screen

image

@dawidkulpa
Copy link

Overall works, but I found one issue:
If a doc doesn't have any tags apart from "paperless-gpt", then after applying suggestions, "paperless-gpt" tag isn't removed from that single document.
Screenshots showing the path:
image
image

When I click "Apply suggestions", titles of them both are applied, "Komputronik" tile disappears, but "Invoice FV/5323" stays there, as the "paperless-gpt" tag wasn't removed from it.

Thanks for the change! :)

@icereed
Copy link
Owner Author

icereed commented Oct 7, 2024

@dawidkulpa Thanks for the catch. That's fixed now :) Also introduced a hover effect on the suggestion review screen to see the content preview of the document. This would close #9.

@icereed icereed merged commit 31f0e81 into main Oct 7, 2024
5 checks passed
@icereed icereed deleted the redesign-tags-titles branch October 7, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants