Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Client and Server created by the Templates output dbug Logging #3840

Closed
InsertCreativityHere opened this issue Dec 4, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@InsertCreativityHere
Copy link
Member

When running the Server or Client application provided by the icerpc-slice-x templates, they output debug logging, which is unexpected.

I'm pasting the entirety of my terminal below, but only the last section showcases the debug logging.

PS C:\Users\Me\Desktop\temp-testing\icerpc-csharp\testing-templates> dotnet new icerpc-slice-server -o MyServer
The template "IceRPC + Slice Server" was created successfully.

Processing post-creation actions...
Restoring C:\Users\Me\Desktop\temp-testing\icerpc-csharp\testing-templates\MyServer\MyServer.csproj:
  Determining projects to restore...
  Restored C:\Users\Me\Desktop\temp-testing\icerpc-csharp\testing-templates\MyServer\MyServer.csproj (in 770 ms).
Restore succeeded.


PS C:\Users\Me\Desktop\temp-testing\icerpc-csharp\testing-templates> cd MyServer
PS C:\Users\Me\Desktop\temp-testing\icerpc-csharp\testing-templates\MyServer> dotnet build
MSBuild version 17.8.3+195e7f5a3 for .NET
  Determining projects to restore...
  All projects are up-to-date for restore.
  MyServer -> C:\Users\Me\Desktop\temp-testing\icerpc-csharp\testing-templates\MyServer\bin\Debug\net8.0\MyServer.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:00:00.83
PS C:\Users\Me\Desktop\temp-testing\icerpc-csharp\testing-templates\MyServer> dotnet run
dbug: IceRpc.Server[11]
      Listener 'icerpc://[::0]?transport=tcp' has started accepting connections
dbug: IceRpc.Server[0]
      Listener 'icerpc://[::0]?transport=tcp' accepted connection from '[::1]:52526'
dbug: IceRpc.Server[3]
      Server connection from '[::1]:4062' to '[::1]:52526' connected
Dispatching greet request { name = 'Me' }
info: IceRpc.Logger.LoggerMiddleware[0]
      Dispatch of greet to /VisitorCenter.Greeter over [::1]:4062<->[::1]:52526 returned a response with status code Ok
dbug: IceRpc.Server[6]
      Server connection from '[::1]:4062' to '[::1]:52526' shutdown
dbug: IceRpc.Server[5]
      Server connection from '[::1]:4062' to '[::1]:52526' disposed
dbug: IceRpc.Server[12]
      Listener 'icerpc://[::0]?transport=tcp' has stopped accepting connections

Note that similar logs are displayed on the client side.

@InsertCreativityHere InsertCreativityHere added the bug Something isn't working label Dec 4, 2023
@InsertCreativityHere
Copy link
Member Author

This probably happens for all the templates.
It at least also happens for the icerpc-protobuf-x templates too.

@pepone pepone added this to the 0.2.1 milestone Dec 4, 2023
@pepone
Copy link
Member

pepone commented Dec 6, 2023

This is also what we use for the Logger examples, what log level do you suggest we use?

@bernardnormier
Copy link
Member

We should use Info for the templates. Debug is fine for the logger examples, that are focused on logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants