Add new authorization example #2257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
reviewed
Dec 9, 2022
pepone
reviewed
Dec 9, 2022
pepone
reviewed
Dec 9, 2022
pepone
reviewed
Dec 9, 2022
pepone
reviewed
Dec 9, 2022
pepone
reviewed
Dec 9, 2022
| using IceRpc.Features; | ||
| using IceRpc.Slice; | ||
|
|
||
| namespace AuthorizationExample; |
There was a problem hiding this comment.
Every other example is in module Demo. Why is this one in AuthorizationExample?
There was a problem hiding this comment.
The module name corresponds to the example name. I don't think the others should all be called Demo.
pepone
reviewed
Dec 12, 2022
pepone
reviewed
Dec 12, 2022
pepone
reviewed
Dec 12, 2022
pepone
reviewed
Dec 12, 2022
Co-authored-by: Reece Humphreys <reecewh@icloud.com>
Co-authored-by: Jose <pepone@users.noreply.github.com>
Co-authored-by: Jose <pepone@users.noreply.github.com>
Co-authored-by: Jose <pepone@users.noreply.github.com>
Co-authored-by: Jose <pepone@users.noreply.github.com>
Co-authored-by: Jose <pepone@users.noreply.github.com>
Co-authored-by: Jose <pepone@users.noreply.github.com>
Co-authored-by: Jose <pepone@users.noreply.github.com>
|
I switched from a byte array to a Guid. However I'm not sure how wise this is since the Guid's are generally not cryptography secure, just random. Using securely generated bytes is probably more correct. 🤷♂️ |
bernardnormier
approved these changes
Dec 13, 2022
| module AuthorizationExample; | ||
|
|
||
| /// The authorization token | ||
| typealias Token = sequence<uint8>; |
There was a problem hiding this comment.
Are we missing an opportunity to illustrate custom here?
There was a problem hiding this comment.
I think that would be beyond the scope of this example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new example to how to use interceptors and middleware to perform per request authorization. Several features included:
/adminpath that requires all requests to be "authenticated" with a token/hellopath that gives a different greeting if the session feature is present.NOTE: still need to add a few more comments to the code.