Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Language Reference #303

Conversation

InsertCreativityHere
Copy link
Member

In the interest of shipping, this PR removes the Slice language reference. We can add it back one it's been better refined.
But I feel time is better spent adding back the doc-comments documentation, and reviewing the other doc pages.

Copy link
Member

@bernardnormier bernardnormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only remove the slice-1-data/slice-2-data entries, not the actual markdown files.

@ReeceHumphreys
Copy link
Contributor

We should only remove the slice-1-data/slice-2-data entries, not the actual markdown files.

I agree, the only thing to note is if we do not remove the markdown files theoretically somone who knows the urls could still access the pages and they would still be crawled by bots.

@InsertCreativityHere
Copy link
Member Author

Alright, I've edited this to only remove the sidebar links and leave the pages intact.
I already checked for links and we have no links to the reference.

Copy link
Member

@bernardnormier bernardnormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a new issue "Add Language reference" that references this PR.

@InsertCreativityHere InsertCreativityHere merged commit 1ca4ecc into icerpc:main Aug 30, 2023
InsertCreativityHere added a commit to InsertCreativityHere/icerpc-docs that referenced this pull request Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants