Restructure top navigation bar #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #391
Our issue with the search still working even on the home page was that we currently show the search button on mobile landing page but not on desktop. This type of inconsitency is bad + makes it confusing to know when to allow the keyboard shortcuts for triggering search.
This PR restructures the navigation so the search bar is always at the top. As such, it moved it out of the side navigation. Additionally, this PR moves the top links to a second row so they have more room to breath since the search bar is now in the top bar. I think this will be needed in the future anyway as we expand the documentation.
Before:
After: