Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-line diagnostic underlining #240

Closed
ReeceHumphreys opened this issue Aug 24, 2022 · 0 comments · Fixed by #302
Closed

Multi-line diagnostic underlining #240

ReeceHumphreys opened this issue Aug 24, 2022 · 0 comments · Fixed by #302
Assignees
Labels
bug Something isn't working

Comments

@ReeceHumphreys
Copy link
Contributor

ReeceHumphreys commented Aug 24, 2022

The new error output system introduced in PR #236 generates mangled underlines for slice errors that span multiple lines. Perhaps we can solve this by allowing Diagnostic to contain an array of Span to avoid whitespace from the beginning of the new line being included in the span.

The following slice shows this error:

module MyModule {
    interface MyInterface {
        op1(i: stream
            int64, j: stream int64);
    }
}

Screen Shot 2022-08-24 at 3 35 33 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants