Diagnostic console output #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
reviewed
Aug 24, 2022
externl
reviewed
Aug 24, 2022
InsertCreativityHere
approved these changes
Aug 24, 2022
|
Also, there's a 'bug' with the underling of multiline errors, that I mentioned to you in person that you should fix before merging. |
Co-authored-by: Austin Henriksen <austin.r.henriksen79@gmail.com>
InsertCreativityHere
approved these changes
Aug 24, 2022
Co-authored-by: Austin Henriksen <austin.r.henriksen79@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds better console when displaying diagnostics to users.
To test it you will have to update
Cargo.tomlinicerpc-csharpto point to this branch. As such, I have added two screenshots of the console output.One screenshot shows the output before the changes and one shows the output after the changes made in this PR.
I welcome any design ideas or changes we want to make!