Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the logic used to compute hashes of our Slice files.
No more extension trait, with multiple implementations; just one function.
The only change in logic is that previously, we would compute a hash for each file separately, then hash all those hashes together:
Now, we just have a single hash engine, which we directly feed all the files into:
I can't think of any adverse effects to this simpler approach, compared to the previous nested-hashing approach.