Query docstring #212
Merged
Query docstring #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #212 +/- ##
============================================
Coverage 55.63% 55.63%
============================================
Files 20 20
Lines 1517 1517
Branches 316 316
============================================
Hits 844 844
Misses 616 616
Partials 57 57
Continue to review full report at Codecov.
|
JessicaS11
approved these changes
Jun 25, 2021
|
Thanks for these updates, @whyjz! |
JessicaS11
added a commit
that referenced
this pull request
Sep 30, 2021
* Add research notice to readme (#206) * Update query docstring (#212) * action to automatically update uml diagrams (#208) * switch to svg * update docs with new uml diagrams. Add visualization class to components list * update action trigger to after approved pull request reviews * update variable names for clarity and in line with common usage (#211) * change 'dataset' to 'product' in core and test code * update 'source' input parameter to 'path' in variables module (part of a not-yet-implemented feature). * tests that require an active NSIDC Earthdata session (#209) * NOTE: using the fixture to successfully start a session can be considered the test * check errors raised by empty query object from bounding box split in openaltimetry visualization (#220) * updated product_summary_info function to latest fields returned by CMR (product_id --> title) (#218) * traffic/downloads statistics updates and limit traffic action to parent repo (#221) * GitHub traffic auto-update to not run traffic action on forks. * remove extra code block from example notebook (#225) * populate v0.4.1 changelog and add to index (#226) Co-authored-by: Yo Yehudi <yochannah@gmail.com> Co-authored-by: Whyjay Zheng <wz278@cornell.edu> Co-authored-by: Romina Piunno <romina.piunno@gmail.com> Co-authored-by: Tian Li <45267156+icetianli@users.noreply.github.com> Co-authored-by: JP Swinski <jp.swinski@nasa.gov>
JessicaS11
pushed a commit
that referenced
this pull request
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi - this is for the discussion in #207. I added a few lines to the Query docstring so users can get a bit more information about the arguments. I do not plan to remove the
filesargument because maybe we will need it someday in the future, as @JessicaS11 mentioned from that issue.P.S. There are 4 commits in total, but the first 3 of them are actually to revert my previous commit (see #171) that is not going to be merged.