implement pyspark numeric operations to pass all/test_numeric.py #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icexelloss
reviewed
Aug 5, 2019
| elif isinstance(expr, types.ColumnExpr): | ||
| # expression must be named for the projection | ||
| expr = expr.name('tmp') | ||
| return self.compile(expr.to_projection()).toPandas()['tmp'] |
There was a problem hiding this comment.
Turns the column expression into a table projection so self.compile() returns a data frame.
icexelloss
reviewed
Aug 6, 2019
ibis/pyspark/client.py
Outdated
| # attach result column to a fake DataFrame and | ||
| # select the result | ||
| compiled = self._session.range(0, 1) \ | ||
| .withColumn("result", compiled) \ |
There was a problem hiding this comment.
I think you can just do
self._session.range(0, 1).select(compiled)
icexelloss
reviewed
Aug 6, 2019
| scale = op.digits.op().value if op.digits is not None else 0 | ||
| rounded = F.round(src_column, scale=scale) | ||
| if scale == 0: | ||
| rounded = rounded.astype('long') |
There was a problem hiding this comment.
Why do we need to cast type here?
There was a problem hiding this comment.
Expected result is np.int64 when decimals or scale is 0. https://github.com/ibis-project/ibis/blob/master/ibis/tests/backends.py#L34
icexelloss
reviewed
Aug 6, 2019
ibis/pyspark/compiler.py
Outdated
| import numpy as np | ||
| op = expr.op() | ||
|
|
||
| @pandas_udf('double', PandasUDFType.SCALAR) |
There was a problem hiding this comment.
Can we rewrite this using sql operations? e.g
F.when(src_column == 0, lit(0)).otherwise(F.when(src_column > 0, lit(1)).otherwise(-1))
icexelloss
pushed a commit
that referenced
this pull request
Aug 7, 2019
* implement pyspark compiler numeric operations to pass all/test_numeric.py
icexelloss
pushed a commit
that referenced
this pull request
Aug 13, 2019
* implement pyspark compiler numeric operations to pass all/test_numeric.py
icexelloss
pushed a commit
that referenced
this pull request
Aug 15, 2019
* implement pyspark compiler numeric operations to pass all/test_numeric.py
icexelloss
pushed a commit
that referenced
this pull request
Aug 15, 2019
* implement pyspark compiler numeric operations to pass all/test_numeric.py
icexelloss
pushed a commit
that referenced
this pull request
Aug 22, 2019
* implement pyspark compiler numeric operations to pass all/test_numeric.py
icexelloss
added a commit
that referenced
this pull request
Sep 12, 2019
This is a Pyspark backend for ibis. This is different from the spark backend where the ibis expr is compiled to SQL string. Instead, the pyspark backend compiles the ibis expr to pyspark.DataFrame exprs. Author: Li Jin <ice.xelloss@gmail.com> Author: Hyonjee Joo <5000208+hjoo@users.noreply.github.com> Closes ibis-project#1913 from icexelloss/pyspark-backend-prototype and squashes the following commits: 213e371 [Li Jin] Add pyspark/__init__.py 8f1c35e [Li Jin] Address comments f173425 [Li Jin] Fix tests 0969b0a [Li Jin] Skip unimplemented tests 1f9409b [Li Jin] Change pyspark imports to optional 26b041c [Li Jin] Add importskip 108ccd8 [Li Jin] Add scope e00dc00 [Li Jin] Address PR comments 4764a4e [Li Jin] Add pyspark marker to setup.cfg 7cc2a9e [Li Jin] Remove dead code 72b45f8 [Li Jin] Fix rebase errors 9ad663f [Hyonjee Joo] implement pyspark numeric operations to pass all/test_numeric.py (#9) 675a89f [Li Jin] Implement compiler rules to pass all/test_aggregation.py 215c0d9 [Li Jin] Link existing tests with PySpark backend (#7) 88705fe [Li Jin] Implement basic join c4a2b79 [Hyonjee Joo] add pyspark compile rule for greatest, fix bug with selection (#4) fa4ad23 [Li Jin] Implement basic aggregation, group_by and window (#3) 54c2f2d [Li Jin] Initial commit of pyspark DataFrame backend (#1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes all numeric tests in
ibis/tests/all/test_numeric.pyexcept fortest_divide_by_zerowhich is skipped for the PySpark backend (PySpark does not support col / 0 = inf).Changes made:
Implemented the following operations: least, abs, round, ceil, floor, exp, sign, sqrt, log, ln, log2, log10, modulus, negate, add, divide, floor divide, isnan, isinf.
Implemented column expression execution for PySpark (needed to pass some of the column tests in test_numeric.py)
Fixed selection operation in the PySpark compiler.
Fixed a few lint errors.