-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dictionary 1.19 merge to master #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lowup_after_clinical_event_id'
…Response Criteria' codelist
… 'Xenograft - derived from metastatic tumour') to 'specimen_type' codelist
Added new term 'physician assessed progressive disease' to 'Physican Assessed Response Criteria' codelist
Added two new terms ('Cell line - derived from metastatic tumour' and 'Xenograft - derived from metastatic tumour') to 'specimen_type' codelist
Added optional field in Donor schema for lost to follow up
Was able to successfully register two tumour specimens using the 2 new specimen_type terms: |
Validation of incorrect IDs fails as expected. Returns an error indicating the submitted IDs do not conform to required regex: |
|
justincorrigible
force-pushed
the
develop
branch
from
October 16, 2023 16:39
bf2cc83
to
31b643f
Compare
All test cases in icgc-argo/argo-clinical#854 were tested in DEV and QA and pass or fail validation as expected. |
lindaxiang
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets to test in QA using Dictionary version
127.1
: