-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Syntax highlighted diff output ✨ #4
base: dev
Are you sure you want to change the base?
Conversation
Thanks for working on this. I'm not a big fan of how much complexity this introduces for just the diff functionality especially as I'm a bit worried about the maintainability of it. Concretely, this branch is a bit out of date (which is important because I just refactored the whole test suite), it needs some typing fixes, and quite a bit of glue code with the commands to handle light themed terminals. I can take over and see if I can resolve these issues myself. I know I've described diff-shades as a hacky bit of software but I'm trying to slowly undo that (eg. see the brand new test suite on main) 🙂 |
Sure, that would be great. Let me know if you come across any difficulty 👍 |
Would appreciate another look at this, bumping in case you forgot this PR exists :D |
9f8c993
to
6ec675b
Compare
Hey @ichard26, hope you are doing well. Do you have any plans on proceeding with this addition? |
A bit hacky but it works, I haven't completely tested it with diff-shades but have tested the
_diff.py
lib separately.Btw, I am logged out of discord and can't log in back (my phone broke and I can't find the recovery codes 😔), so keep the conversation here.
And happy new year! (a bit late)