Skip to content

Commit

Permalink
ci: run tests with and without PAPI debug enabled
Browse files Browse the repository at this point in the history
Tests should make sure real use cases work as expected. Some tests might
not working correctly if -O0 is used as optimization level in the
compiler. For example, the ROCm runtime submits a kernel of 4 waves if
the tests are built using -O0, which makes the tests fail.

Update the github test configuration matrix to include testing without
PAPI debug.
  • Loading branch information
gcongiu committed Dec 5, 2023
1 parent ef1cc48 commit 307554c
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/ci.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
#!/bin/bash -e

COMPONENT=$1
COMPILER=$2
DEBUG=$2
COMPILER=$3

[ -z "$COMPILER" ] && COMPILER=gcc@11

Expand Down Expand Up @@ -43,9 +44,9 @@ if [ "$COMPONENT" = "infiniband_umad" ]; then
fi

if [ "$COMPONENT" = "perf_event" ]; then
./configure --with-debug=yes --enable-warnings
./configure --with-debug=$DEBUG --enable-warnings
else
./configure --with-debug=yes --enable-warnings --with-components=$COMPONENT
./configure --with-debug=$DEBUG --enable-warnings --with-components=$COMPONENT
fi

make -j4
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,35 +14,38 @@ jobs:
strategy:
matrix:
component: [perf_event, lmsensors, io, net, powercap, appio, coretemp, stealtime]
debug: [yes, no]
fail-fast: false
runs-on: cpu_intel
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
- name: Test
run: .github/workflows/ci.sh ${{matrix.component}}
run: .github/workflows/ci.sh ${{matrix.component}} ${{matrix.debug}}
papi_component_nvidia:
strategy:
matrix:
component: [cuda, nvml]
debug: [yes, no]
fail-fast: false
runs-on: gpu_nvidia
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
- name: Test
run: .github/workflows/ci.sh ${{matrix.component}}
run: .github/workflows/ci.sh ${{matrix.component}} ${{matrix.debug}}
papi_component_amd:
strategy:
matrix:
component: [rocm, rocm_smi]
debug: [yes, no]
fail-fast: false
runs-on: gpu_amd
timeout-minutes: 60
steps:
- uses: actions/checkout@v3
- name: Test
run: .github/workflows/ci.sh ${{matrix.component}}
run: .github/workflows/ci.sh ${{matrix.component}} ${{matrix.debug}}
papi_spack:
runs-on: cpu
timeout-minutes: 60
Expand Down

0 comments on commit 307554c

Please sign in to comment.