2024.12.11 intel gpu threads #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adanalis
approved these changes
Dec 11, 2024
dbarry9
force-pushed
the
2024.12.11_intel-gpu-threads
branch
from
7c341a6 to
1297c8a
Compare
Treece-Burgess
approved these changes
Dec 12, 2024
Treece-Burgess
added
component-intel_gpu
Since the intel_gpu component uses mutexes, which use POSIX threads on some systems, -pthread needs to be used when this component is configured-in. These changes have been tested on the Intel Max 1550 GPU.
Since the flag -lstdc++ is already included from the configure script, it does not need to be included in the component's Rules and Makefiles. Also, -g is already included in the recipes, it is not needed in the linker flags variable. These changes have been tested on the Intel Max 1550 GPU.
dbarry9
force-pushed
the
2024.12.11_intel-gpu-threads
branch
from
1297c8a to
2f265ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request introduces changes to address Issue #283.
These changes have been tested on the Intel Max 1550 GPU.
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests