rocprofiler issue80 fixup #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gcongiu, will give this a try on my side. |
adanalis
approved these changes
Oct 11, 2023
gcongiu
force-pushed
the
2023.10.06_issue80-fixup
branch
from
78fbc4d to
332e706
Compare
Issue icl-utk-edu#80 was causing sampling mode multithreading not to work. This was caused by a bug in the rocm component that tried to monitor multiple GPU devices using the using the same rocprofiler queue. Assigning one independent queue per device solves the issue.
gcongiu
force-pushed
the
2023.10.06_issue80-fixup
branch
from
332e706 to
3d290c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fix rocprofiler issue80: ROCm/rocprofiler#80 (comment).
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests