For enums, use to_string, from_string. #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgates3
force-pushed
the
to_string
branch
4 times, most recently
from
533c02d to
c2abaaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on icl-utk-edu/testsweeper#21 and icl-utk-edu/blaspp#77 and icl-utk-edu/lapackpp#57
Builds on PR #164: change methods to enums, for consistency with other options.
Due to deprecated functions in TestSweeper, it was convenient to fold PR #164 into this PR.
Use standard
to_stringfunction to convert enum to string.Introduce
to_charandto_c_stringfunctions.Introduce
from_stringfunction to convert string to enum.This also makes the ParamEnum constructor much simpler.
Added some timers to the examples
run_tests.py, to help debug the CI taking 1:30 h:mm in the CPU tests (see #181). When I run it manually on methane, the examples take 0:01 h:mm. ... Of course now, themake, cpubuild takes 0:07 h:mm. Go figure.