-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete photo/video after download successful #431
Delete photo/video after download successful #431
Conversation
I downloaded all of my photos using the normal docker template in unraid, then I saw your changes and ran them locally on my windows machine, pointed at the same share as my unraid install -- it's working great! Finally, I can free up space in our shared iCloud account! Thanks |
cool!+1 |
can we merge this change please? |
+1 Much needed feature. Can it be merged please? |
+1 Yes, can this feature be merged please? @Nasipuk |
@MatrixDai do you mind rebasing your diff, please? Thanks for providing tests for new functionality. |
53bf831
to
c3fb2d2
Compare
@AndreyNikiforov Rebased with the master branch. |
Quality checks are failing ;-( Please fix those. You can run these checks locally (scripts/lint & script/test after installing all dependencies of course) |
Now, fixed lint and tests. @AndreyNikiforov |
Yes, due to stale dependencies we have 3.9 as max supported version of Python now. You can run .devcontainer with 3.9 either locally or in Github Codespaces. Although containers are running Linux, Quality checks Github actions run on MacOs and Windows as well. |
Added a new command line option
--delete-after-download
to allow user delete the photo right after download complete. The deleted items will moved to "Recent Deleted" system album.The implementation reference from this gist.
Related discussions:
#368 #314 #124 #332