Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete photo/video after download successful #431

Conversation

MatrixDai
Copy link
Contributor

@MatrixDai MatrixDai commented May 10, 2022

Added a new command line option --delete-after-download to allow user delete the photo right after download complete. The deleted items will moved to "Recent Deleted" system album.

The implementation reference from this gist.

Related discussions:
#368 #314 #124 #332

@newone757
Copy link

I downloaded all of my photos using the normal docker template in unraid, then I saw your changes and ran them locally on my windows machine, pointed at the same share as my unraid install -- it's working great! Finally, I can free up space in our shared iCloud account! Thanks

@seiry-apt
Copy link

cool!+1

@FinalTheory
Copy link

can we merge this change please?

@pawsie
Copy link

pawsie commented Sep 24, 2022

+1 Much needed feature. Can it be merged please?

@olegcarguy
Copy link

+1 Yes, can this feature be merged please? @Nasipuk

@AndreyNikiforov
Copy link
Collaborator

@MatrixDai do you mind rebasing your diff, please? Thanks for providing tests for new functionality.

@MatrixDai MatrixDai force-pushed the feature/delete-photo-after-download branch from 53bf831 to c3fb2d2 Compare January 20, 2023 00:26
@MatrixDai
Copy link
Contributor Author

@MatrixDai do you mind rebasing your diff, please? Thanks for providing tests for new functionality.

@AndreyNikiforov Rebased with the master branch.

@AndreyNikiforov
Copy link
Collaborator

@MatrixDai do you mind rebasing your diff, please? Thanks for providing tests for new functionality.

@AndreyNikiforov Rebased with the master branch.

Quality checks are failing ;-( Please fix those.

You can run these checks locally (scripts/lint & script/test after installing all dependencies of course)

@MatrixDai
Copy link
Contributor Author

Now, fixed lint and tests. @AndreyNikiforov
Sorry didn't check locally, as I have upgrade local python to 3.11, it seems like the local develop env require python 3.9 on macOS M1.

@AndreyNikiforov AndreyNikiforov merged commit 18efdfe into icloud-photos-downloader:master Jan 23, 2023
@AndreyNikiforov
Copy link
Collaborator

Now, fixed lint and tests. @AndreyNikiforov Sorry didn't check locally, as I have upgrade local python to 3.11, it seems like the local develop env require python 3.9 on macOS M1.

Yes, due to stale dependencies we have 3.9 as max supported version of Python now. You can run .devcontainer with 3.9 either locally or in Github Codespaces. Although containers are running Linux, Quality checks Github actions run on MacOs and Windows as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants