Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warning about pydicom_compat #145

Open
abrys opened this issue May 8, 2024 · 1 comment
Open

Fix deprecation warning about pydicom_compat #145

abrys opened this issue May 8, 2024 · 1 comment
Assignees
@abrys
Labels
enhancement

Comments

@abrys
Copy link
Collaborator

abrys commented May 8, 2024

When importing "convert_dicom.py" in an environment with a recent version of nibabel you get the following deprecation warning
This is due to an import of pydicom using nibabel.pydicom_compat instead of a direct import

dicom2nifti/convert_dicom.py:13: DeprecationWarning: We will remove the 'pydicom_compat' module from nibabel 7.0. Please consult pydicom's documentation for any future needs.

    from nibabel.pydicom_compat import pydicom
@abrys abrys self-assigned this May 8, 2024
abrys added a commit that referenced this issue May 8, 2024
@abrys
#145:
816923f 
Fix the import so it is a direct import of pydicom to avoid the deprecation warning
abrys added a commit that referenced this issue May 8, 2024
@abrys
#145:
1471a23 
Prepare for release of 2.4.11
@jdhenckel
Copy link

please accept my PR #105 it is very important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrys abrys

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdhenckel @abrys